Merge OpenAI Triton commit 13594bb
#2580
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
changed the title
3889f3f3b97b817741e308c173409927b7c4536f13594bbf4571fbee066fe45fb8b1874690598e97
whitneywhtsang
approved these changes
Oct 28, 2024
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
Thanks for doing the change! Can you please redo the changes on top of the latest main? Reminder to not squash and merge.
…ty (intel#4968) We add a new abstraction `LL::quotient` that abstracts the idea of "a linear layout does not permute certain dimensions". Doing so, allows us to remove `divideRight` and subsume them into this higher-level abstraction. We also fix a bug in `isCrossCTAConversion`. We also remove some code duplication from `transferWithinThreads` and `cvtReorderRegisters` in favour of a more generic approach. We fix a bug in `sublayout` that meant that `sublayout` would reorder `outDims` at will by using a set instead of a vector. I am missing adding tests for LL::quotient, will do in a minute.
Replace `divideRight` calls with `quotient` calls and simplify code following upstream model. Signed-off-by: victor-eds <[email protected]>
whitneywhtsang
force-pushed
the
rebase
branch
from
4581c79 to
7370611
Compare
whitneywhtsang
changed the title
13594bbf4571fbee066fe45fb8b1874690598e9713594bb
Contributor
|
Not sure how to rebase correctly with your repo, so rebased again here: #2582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the Triton base from 3613bf4 to 13594bb (Oct 24).
Pass rate: 98.98%
Please do not squash and merge this PR.